search

googlearchive / paper-radio-group

A group of radio buttons
6 stars 4 forks source link

Multiple radio buttons can be selected in the group. #3

Closed pstjvn closed 10 years ago

pstjvn commented 10 years ago

To duplicate:

Open Chrome dev editor. Create a package and in bower config require as deps Polymer/paper-elements#master Bower update Open demo of paper-radio-group

Expected result = demo should work Actual result = All radio buttons can be selected

Tested on Chrome 36 Linux.

addyosmani commented 10 years ago

I'm unable to repro this issue using http://www.polymer-project.org/components/paper-radio-group/demo.html in Chrome stable (36) or later versions. It's possible that the version of paper-radio-group used in Chrome Dev Editor is older than the one in master at the moment.

cc @ussuri who works on the editor and may know more.

pstjvn commented 10 years ago

@addyosmani On the website everything works. I don't think it is related to the editor, it only does bower update/install which means I have fresh copy of master branch locally. Is the site using master branch and constantly updating to sync with it?

addyosmani commented 10 years ago

Are you sure the editor is pulling in master? I ask as it's possible they've locked to using a specific version but again might be useful for @ussuri to provide input here.

pstjvn commented 10 years ago

@addyosmani I have tried bower update from console - it run successfully and then I use local node.js server and sublime text - so basically I cannot see the link with CDE. In bower.json I have:

"dependencies": { "polymer": "Polymer/polymer#master", "core-elements": "Polymer/core-elements#master", "paper-elements": "Polymer/paper-elements#master" }

Maybe my config is wrong?

pstjvn commented 10 years ago

Confirmed, it only happens in #master. In 0.3.4 is works fine, I just wrongly assumed it should also work in master.

ussuri commented 10 years ago

CDE tries to satisfy exact version specifications in a given bower.json. We support simple version specs, like "Polymer/polymer#master" or "Polymer/polymer#0.3.0". However, we don't yet fully support more complex ones, like "Polymer/polymer#'0.2.0 - 0.4.0'" or "Polymer/polymer#^0.3.0". For the latter, we'll either pull the master, or an overridden version for that dependency. After each 'bower install' or 'bower upgrade' (which covers creation of a new project as well), CDE will print a very detailed report to the console about what version substitutions have been made, and how to reconfigure it to do something different. It's all not perfect in terms of the UX, but it does give you all the tools to download exactly what you need.

On Thu, Jul 31, 2014 at 10:30 AM, pstjvn notifications@github.com wrote:

Confirmed, it only happens in #master. In 0.3.4 is works fine, I just wrongly assumed it should also work in master.

— Reply to this email directly or view it on GitHub https://github.com/Polymer/paper-radio-group/issues/3#issuecomment-50791301 .

sorvell commented 10 years ago

Sorry for the trouble. Please re-open the issue if this persists with the current release 0.3.5 or re-surfaces after.