search

googlearchive / paper-tabs

A tabs à la Material Design
22 stars 21 forks source link

Ripple broken on drag in IE11 #43

Open xwcg opened 9 years ago

xwcg commented 9 years ago

In IE11 (11.0.9600.17239) the ripple does not disappear if a drag operation is initiated as seen on this video: http://gfycat.com/QueasyCalmHerculesbeetle does not occur on other elements that use a paper ripple effect.

frankiefu commented 9 years ago

I can't seem to reproduce the issue in the demo in IE11. If you have a jsbin showing the issue that would be great.

xwcg commented 9 years ago

I can't manage to get Polymer to run in JSBin (Cross-Origin Resource Sharing problem), but I put up the stripped version of the html that is causing the issues: http://jsbin.com/kokibafeno/1/edit?html,output

xwcg commented 9 years ago

Oh, I am using the "link" tabs, I should have mentioned that. They exhibit the same behaviour on the demo site: http://gfycat.com/NextForsakenHagfish

frankiefu commented 9 years ago

I think is the <a> inside the paper-tab causing the dragging side effect on ripple. You can make the <a> not draggable by setting draggable=false. Like this: http://jsbin.com/qesijeremo/1/edit

xwcg commented 9 years ago

That seems to have fixed it! Thanks!

I would still suggest to either update the documentation for the paper tabs and warn of this behaviour with "link ink-tabs" and how to avoid it, or to just automatically prevent it somehow.