search

googlearchive / paper-tabs

A tabs à la Material Design
22 stars 21 forks source link

added keyboard navigation to link tabs #51

Open jannakha opened 9 years ago

jannakha commented 9 years ago

added core-a11y-keys element to paper-tab for keyboard navigation

googlebot commented 9 years ago

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

robdodson commented 9 years ago

@morethanreal would it be possible to merge this in + mixing in Polymer.CoreFocusable?

robdodson commented 9 years ago

sorry, just realized I should have pinged @frankiefu

jannakha commented 9 years ago

I signed CLA, it still shows as 'no'

googlebot commented 9 years ago

CLAs look good, thanks!

robdodson commented 9 years ago

@jannakha do you know if this works if there's an anchor inside of the paper-tab? will the listener for enter intercept it and prevent the anchor from being clicked?