search

googlearchive / paper-toast

A lightweight feedback about an operation in a small popup at the base of the screen on mobile and at the lower left on desktop.
17 stars 8 forks source link

paper-toast "Uncaught RangeError: Maximum call stack size exceeded" when toast is shown several times #7

Closed mmatheson1 closed 10 years ago

mmatheson1 commented 10 years ago

To repeat, make a button to show a toast. Click it several times (can repeat sometimes with 5 clicks, sometimes with 20+) with the console open. Clicking faster seems to surface the error faster.

Object.defineProperty.get polymer.js:1 (anonymous function) VM95:4 createObject.check_ observe.js:1033 dirtyCheck observe.js:438 Observer.deliver observe.js:751 Object.defineProperty.get properties.js:130 Polymer.applyFocus core-overlay.js:350 focusOverlay core-overlay.js:555 Polymer.applyFocus core-overlay.js:354 focusOverlay core-overlay.js:555 Polymer.applyFocus core-overlay.js:354 focusOverlay core-overlay.js:555 Polymer.applyFocus core-overlay.js:354 focusOverlay core-overlay.js:555 Polymer.applyFocus core-overlay.js:354 focusOverlay core-overlay.js:555 Polymer.applyFocus core-overlay.js:354 focusOverlay core-overlay.js:555

addyosmani commented 10 years ago

I was able to repro this in Chrome 36. I wasn't able to repro the same with <core-overlay> for what it's worth.

screen shot 2014-08-01 at 17 26 22

frankiefu commented 10 years ago

This is an issue in core-overlay. This pull request should fix this: https://github.com/Polymer/core-overlay/pull/3

frankiefu commented 10 years ago

fixed by https://github.com/Polymer/core-overlay/pull/3