search

googlearchive / pedantic

How to get the most value from Dart static analysis
https://pub.dev/packages/pedantic
BSD 3-Clause "New" or "Revised" License
324 stars 56 forks source link

Remove unsafe_html #83

Closed srawlins closed 3 years ago

srawlins commented 3 years ago

While unsafe_html is an enabled lint at Google, it really only makes sense because of our build rules, access controls, concepts of "owners," etc.

I think users are getting more frustrated and confused by this lint rule, and the fact that you cannot // ignore: violations. See https://github.com/dart-lang/sdk/issues/45230 and https://github.com/dart-lang/linter/issues/2348.

I think it should be removed from the list provided in pedantic's analysis options.

davidmorgan commented 3 years ago

Thanks Sam.

I don't think this is the right place to fix the issue; pedantic isn't supposed to be anything more than the list of lints we use in google3.

@mit-mit is working on publishing separate lists which are tailored for external users.

srawlins commented 3 years ago

The lints package is now published without unsafe_html so problem solved. 😁