☂ platinum-bluetooth 2.0

googlearchive / platinum-bluetooth

A set of Polymer elements to discover and communicate with nearby Bluetooth devices

https://elements.polymer-project.org/elements/platinum-bluetooth

Apache License 2.0

22 stars 13 forks source link

☂ platinum-bluetooth 2.0 #15

Closed beaufortfrancois closed 8 years ago

beaufortfrancois commented 8 years ago

This PR includes:

new <platinum-bluetooth-service> element
notifications support
device disconnect
remove unnecessary checks
switch to DataView
new name and name prefix filters

R=@jeffposnick @jyasskin

beaufortfrancois commented 8 years ago

@jeffposnick Do you know what are the steps required to trigger tedium to update my README file?

jeffposnick commented 8 years ago

No idea re: @tedium-bot. Maybe @ebidel or @addyosmani know?

jeffposnick commented 8 years ago

Reviewed! Some small style things, but otherwise seems good to me. As with all the Bluetooth stuff, I'm not sure I can provide meaningful feedback about the lower-level API, though.

beaufortfrancois commented 8 years ago

Thank you for your review @jeffposnick. I've addressed all nits.

@jyasskin (gentle ping)

jyasskin commented 8 years ago

Otherwise LGTM.

beaufortfrancois commented 8 years ago

I've addressed all your feedback @jyasskin