googlearchive / polyclean

BSD 3-Clause "New" or "Revised" License
20 stars 7 forks source link

Allow uglifyjs options #6

Closed Everlag closed 8 years ago

Everlag commented 9 years ago

Some libraries break with mangling enabled, we should accommodate them.

Notably, rickshaw is broken due to the mangling that uglify performs by default. https://github.com/shutterstock/rickshaw/issues/52 specifically addresses this.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


Everlag commented 9 years ago

I signed it!

googlebot commented 9 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 9 years ago

CLAs look good, thanks!

dfreedm commented 8 years ago

LGTM