search

googlearchive / polylint

Lint polymer!
BSD 3-Clause "New" or "Revised" License
116 stars 19 forks source link

Correct binding expression regex to match non greedily (Fixes #113) #116

Closed jonvuri closed 8 years ago

jonvuri commented 8 years ago

With this fix, the binding expressions regex will correctly match binding expressions on the same line individually rather than greedily matching between both of their {{ and }}.

I also renamed the oddly named compound-binding.html test component to property-not-found.html, and made a new compound-binding.html with an actual compound binding, which is the use case that usually hits this bug.

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 8 years ago

CLAs look good, thanks!

jonvuri commented 8 years ago

Closing for better regex