googlearchive / polymer-element-catalog

A catalog of Polymer-based web components built by the Polymer team
BSD 3-Clause "New" or "Revised" License
164 stars 91 forks source link

Support for absolute bower URLs #289

Open sfeederle opened 7 years ago

sfeederle commented 7 years ago

If bower dependencys are saved as URLs (https://bower.io/#install-packages) instead of Github shorthands the Source link in the UI breaks. This is because 'https://github.com/' is always appanded to the front of the source, even if its already a hyperlink.

This fix enables URLs in bower dependencies, even to private github enterprise servers like:

"dependencies": {
    "my-element": "https://github.customdomain.com/elements/my-element.git#^1.0.0"
}
googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.