Ported pinch gesture - Githubissues

googlearchive / polymer-gestures

84 stars 27 forks source link

Ported pinch gesture #49

Closed sbmaxx closed 10 years ago

sbmaxx commented 10 years ago

Just ported pinch gesture from PointerEvents repository and added a simple example of it.

I not tested, but maybe it requires those PR to be merged first https://github.com/Polymer/polymer-gestures/pull/48 https://github.com/Polymer/polymer-gestures/pull/47

At least i had to fix them before i could start porting pinch;

dfreedm commented 10 years ago

Sorry for the delay in looking at this. I think this is a great start, but just needs a few bits of cleanup. I'll go ahead and merge this, then make the cleanup commits.

sbmaxx commented 10 years ago

You can tell me what to fix, and i'll make it ;)

dfreedm commented 10 years ago

Ok, here's what I've seen so far:

Since pinch and rotate need to prevent scrolling, the recognizer needs to have defaultActions of none for the pinch and rotate gesture like this: https://github.com/Polymer/polymer-gestures/blob/master/src/track.js#L123-L127
The calls to makeGestureEvent should have bubbles: true, cancelable: true, and _source: "pinch" properties set.
There should be some sample for rotate too, if only logging the angle.