search

googlearchive / polymer-gestures

84 stars 27 forks source link

basic api documentation #55

Closed forresto closed 10 years ago

sbmaxx commented 10 years ago

:+1:

ebidel commented 10 years ago

Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide.

forresto commented 10 years ago

I have.

ebidel commented 10 years ago

What email did you use?

forresto commented 10 years ago

forresto.com or sembiki.com ?

forresto commented 10 years ago

But I'm not 100% sure this documentation is right, now. I got my stuff working in the-graph by making the PolymerGestures event listeners at the root level, with noop handlers. Then all of the normal element.addEventListener s started to work.

https://github.com/the-grid/the-graph/commit/421be402699d5bb537af111823a4a841427d18ac

forresto commented 10 years ago

OK, signed again.

addyosmani commented 10 years ago

Thanks for signing the CLA!

dfreedm commented 10 years ago

LGTM

forresto commented 10 years ago

What about the confusion w/ https://github.com/Polymer/polymer-gestures/pull/55#issuecomment-54545615

steida commented 10 years ago

"Should have"? What does it mean? Gestures work without touch action?