Closed robliao closed 9 years ago
The Closure Compiler treats variables in ALL_CAPS as constants. The changes below mutate various ALL_CAPS style variables. Would it be possible to rename them into something that doesn't use ALL_CAPS style naming?
HAS_FULL_PATH to hasFullPath https://github.com/Polymer/polymer-gestures/commit/f6d8ba8daa958197808e86cdb6300aab157c2d0b#diff-cd169a97e1ee490bb66c7212c356db70R23
HAS_FULL_PATH
hasFullPath
CURRENT_BUTTONS to currentButtons https://github.com/Polymer/polymer-gestures/commit/7f69799013349a0c6742c06f0bb4633b3b4c5f3a#diff-cb5ce8a99b7664dcb2045bf8ad34f2b4R70
CURRENT_BUTTONS
currentButtons
The Closure Compiler treats variables in ALL_CAPS as constants. The changes below mutate various ALL_CAPS style variables. Would it be possible to rename them into something that doesn't use ALL_CAPS style naming?
HAS_FULL_PATHtohasFullPathhttps://github.com/Polymer/polymer-gestures/commit/f6d8ba8daa958197808e86cdb6300aab157c2d0b#diff-cd169a97e1ee490bb66c7212c356db70R23CURRENT_BUTTONStocurrentButtonshttps://github.com/Polymer/polymer-gestures/commit/7f69799013349a0c6742c06f0bb4633b3b4c5f3a#diff-cb5ce8a99b7664dcb2045bf8ad34f2b4R70