googlearchive / polymer-gestures

84 stars 27 forks source link

'bubbles' and 'cancelable' properties of an Event are not writable. Fix... #85

Closed thomasmarkiewicz closed 9 years ago

thomasmarkiewicz commented 9 years ago

...ed code so it doesn't attempt to set those properties.

According to this:

https://developer.mozilla.org/en-US/docs/Web/API/Event.initEvent

'bubbles' and 'cancelable' properties of an Event are read-only. They are set once when the Event is first initialized with

e.initEvent(inType, inDict.bubbles || false, inDict.cancelable || false);

in makeBaseEvent(...)

The two places I found here attempt to write to those properties causing an exception when running a polymer mobile chrome app on iOS 8.1 (build with cca tool).

Related: https://github.com/webcomponents/webcomponentsjs/pull/122

dfreedm commented 9 years ago

LGTM