search

googlearchive / polymer-tutorial

Deprecated Polymer 0.5 tutorial app
211 stars 125 forks source link

Update post-card.html #27

Closed Tusiji closed 9 years ago

Tusiji commented 10 years ago

"color" is not work here！use “fill” to change the color of icons.

robdodson commented 10 years ago

color should work if you're using core-icon >= v0.3.5. Are you perhaps using an older version of the tutorial?

Tusiji commented 10 years ago

I'm a rookie on coding. I just download the simples on the website ( http://www.polymer-project.org/docs/start/tutorial/intro.html )

2014-09-06 4:02 GMT+08:00 Rob Dodson notifications@github.com:

color should work if you're using core-icon >= v0.3.5. Are you perhaps using an older version of the tutorail?

— Reply to this email directly or view it on GitHub https://github.com/Polymer/polymer-tutorial/pull/27#issuecomment-54674240 .

arthurevans commented 10 years ago

Hmm... That's strange. Is it possible that you downloaded the tutorial repo a day or two before you tried the tutorial?

The version of Polymer in the tutorial sample files should be 0.4.0. You can check this by looking at the following file:

components/polymer/.bower.json

You should see a version number like this:

 "version": "0.4.0",

If you have an earlier version, please download a new version of the sample files.

ebidel commented 10 years ago

Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide.

Tusiji commented 10 years ago

i have download the latest version. Thx

2014-09-10 0:25 GMT+08:00 Arthur Evans notifications@github.com:

Hmm... That's strange. Is it possible that you downloaded the tutorial repo a day or two before you tried the tutorial?

The version of Polymer in the tutorial sample files should be 0.4.0. You can check this by looking at the following file:

components/polymer/.bower.json

You should see a version number like this:

"version": "0.4.0",

If you have an earlier version, please download a new version of the sample files.

— Reply to this email directly or view it on GitHub https://github.com/Polymer/polymer-tutorial/pull/27#issuecomment-54996616 .

addyosmani commented 9 years ago

@Tusiji can this issue now be closed? I assume the latest version should no longer have the problems described.

Tusiji commented 9 years ago

OK，close it please. I am so sorry for my fault . On Oct 6, 2014 8:09 PM, "Addy Osmani" notifications@github.com wrote:

@Tusiji https://github.com/Tusiji can this issue now be closed? I assume the latest version should no longer have the problems described.

— Reply to this email directly or view it on GitHub https://github.com/Polymer/polymer-tutorial/pull/27#issuecomment-58007996 .

addyosmani commented 9 years ago

No worries at all :)