search

googlearchive / polymer-tutorial

Deprecated Polymer 0.5 tutorial app
211 stars 125 forks source link

setting z-index to 1 so button is visible #30

Closed davidcalhoun closed 9 years ago

davidcalhoun commented 9 years ago

A completely white button on a white background is really confusing otherwise.

davidcalhoun commented 9 years ago

Heads up: I just signed the CLA and added my name to CONTRIBUTORS https://github.com/Polymer/polymer.github.io/pull/22

arthurevans commented 9 years ago

Sorry for the late response here. It seems like this is a PR for the paper-shadow component, not the tutorial.

https://github.com/Polymer/paper-shadow

davidcalhoun commented 9 years ago

Thanks for the reply. This is actually not a bug with paper-shadow - it's an issue with usage of paper-shadow in the context of the polymer-tutorial. When the z-index is set to 0 on the tutorial, the button is completely invisible against the background of the tutorial page. It needs to be set to 1 so the tutorial user can see it on initial page load.

arthurevans commented 9 years ago

The changes in this PR are to the paper-shadow demo, which is part of the paper-shadow repo, here:

https://github.com/Polymer/paper-shadow/blob/master/demo.html

Everything in the components/ folder here is a downstream copy of one of the Polymer components maintained elsewhere. They're included here so users can download a single ZIP file with all the components they need.

davidcalhoun commented 9 years ago

Ah, my bad - I didn't realize that. Thanks for the clarification - I'll close this out.

davidcalhoun commented 9 years ago

Didn't realize the demo had been updated and fixed as well - I should've checked on that.