search

googlearchive / polymer-tutorial

Deprecated Polymer 0.5 tutorial app
211 stars 125 forks source link

remove function slice in postsLoaded: function() #41

Open MacTheZazou opened 9 years ago

MacTheZazou commented 9 years ago

slice() function is unnecessary and can be confusing for the beginner.

googlebot commented 9 years ago

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

MacTheZazou commented 9 years ago

It's done!

2015-02-16 17:12 GMT+01:00 googlebot notifications@github.com:

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA https://cla.developers.google.com/clas or see this help article on setting the email on your git commits https://help.github.com/articles/setting-your-email-in-git/.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

— Reply to this email directly or view it on GitHub https://github.com/Polymer/polymer-tutorial/pull/41#issuecomment-74532148 .

googlebot commented 9 years ago

CLAs look good, thanks!