googlearchive / polymer-tutorial

Deprecated Polymer 0.5 tutorial app
211 stars 125 forks source link

Fix css specifity bug with favorite icon #42

Closed yavorski closed 7 years ago

yavorski commented 9 years ago

If i change the first item in api/posts.json to this, where the actual change is "favorite": true, the favorite icon stays the same (not changing to red) until you hover it.

{
  "uid": 1,
  "text" : "Have you heard about the Web Components revolution?",
  "username" : "Eric",
  "avatar" : "../images/avatar-01.svg",
  "favorite": true
}

Seems this selector is not working in the beginning until you hover the icon:

:host([favorite]) core-icon-button {
  color: #da4336;
}
googlebot commented 9 years ago

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

yavorski commented 9 years ago

@googlebot done :)