search

googlearchive / polyup

A helpful assistant for migrating from Polymer v0.5 to 1.0. Does many of the boring mechanical parts for you.
http://polymerlabs.github.io/polyup/
BSD 3-Clause "New" or "Revised" License
38 stars 9 forks source link

Use Custom Element for Ace editor, #96

Closed tomalec closed 9 years ago

tomalec commented 9 years ago

As in #89 - there is a custom element for ace editor

rictic commented 9 years ago

Very cool, the API is so much simpler this way. Just one question/suggestion, otherwise this looks good to me.

This page is just for local testing, but the github pages site is very similar. I'll do the corresponding update next time I change it (or I can accept a PR if you want to send it!).

Note: I've manually verified that tomalec@ has signed the CLA. I should probably get the CLA robot to check on polyup PRs…

tomalec commented 9 years ago

input.value changes - thanks, I've missed it.

Here is the PR for gh-pages https://github.com/PolymerLabs/polyup/pull/97