search

googlearchive / py-gfm

This repository is unmaintained. Please see Zopieux/py-gfm for the new canonical repository.
https://github.com/Zopieux/py-gfm
BSD 3-Clause "New" or "Revised" License
73 stars 30 forks source link

Update extension initialize method. #17

Closed nekoya closed 9 years ago

nekoya commented 9 years ago

I met the error working with Python-Markdown 2.5.2.

  File "/path/to/venv/local/lib/python2.7/site-packages/markdown/extensions/__init__.py", line 36, in __init__
    self.setConfigs(kwargs.pop('configs', {}))
  File "/path/to/venv/local/lib/python2.7/site-packages/markdown/extensions/__init__.py", line 75, in setConfigs
    for key, value in items:
TypeError: 'NoneType' object is not iterable

I've created a pull request for Python-Markdown, but it was not merge.

https://github.com/waylan/Python-Markdown/pull/385

This pull request fix this error and deprecated usage.

googlebot commented 9 years ago

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

nekoya commented 9 years ago

I submitted the CLA, please check it.

googlebot commented 9 years ago

CLAs look good, thanks!

nekoya commented 9 years ago

Sorry, I made a mistake.