googlearchive / py-gfm

This repository is unmaintained. Please see Zopieux/py-gfm for the new canonical repository.

BSD 3-Clause "New" or "Revised" License

73 stars 30 forks source link

unittest2 required? #24

Closed joshkel closed 8 years ago

joshkel commented 9 years ago

Why require unittest2 in setup.py? Wouldn't that better be handled by a dev-requirements.txt or similar, so that apps don't have to pull in unittest2 and its dependencies just to use py-gfm?

nex3 commented 9 years ago

I'm mostly not a Python developer, so I'd imagine I copied it from somewhere. If that's not ideal, feel free to submit a pull request.

joshkel commented 9 years ago

I'm mostly not a Python developer either, which is why I wanted to run it by you before opening a PR, but I just submitted #25 to address this. Thanks.

zopieux commented 8 years ago

25 was merged, this issue can be closed.