RelativeScaleAnimationView crash with div by zero

googlearchive / science-journal-ios

Use the sensors in your mobile devices to perform science experiments. Science doesn’t just happen in the classroom or lab—tools like Science Journal let you see how the world works with just your phone.

https://sciencejournal.withgoogle.com/

Apache License 2.0

536 stars 62 forks source link

RelativeScaleAnimationView crash with div by zero #28

Closed taquitos closed 5 years ago

taquitos commented 5 years ago

Checklist

[x] All new and existing tests pass
[x] I've read the Contribution Guidelines
[x] I've read Change Limitations

Motivation and Context

Getting a couple crashes due to div by zero.

Description

Instead of comparing to 0 we compare to ulpOfOne, since these are doubles and computer math is hard 🙃

taquitos commented 5 years ago

Nope, this won't fix it. I was able to to repro the crash we're seeing, so we'll have a new fix.