googlearchive / science-journal-ios

Use the sensors in your mobile devices to perform science experiments. Science doesn’t just happen in the classroom or lab—tools like Science Journal let you see how the world works with just your phone.
https://sciencejournal.withgoogle.com/
Apache License 2.0
536 stars 62 forks source link

Resolves extra padding on recording cell top edge #49

Closed samgrover closed 5 years ago

samgrover commented 5 years ago

Checklist

Motivation and Context

https://github.com/google/science-journal-ios/issues/46

Description

Provide zero section insets when there are no cells in the corresponding section.

Manual testing of various UI states in multiple orientations, on iPhone and iPad simulators.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

samgrover commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

samgrover commented 5 years ago

Updated using your code, with a minor change to use data source instead of collection view in the first block.

Also, removed the outdated comments on the method as per our discussion.