googlearchive / science-journal-ios

Use the sensors in your mobile devices to perform science experiments. Science doesn’t just happen in the classroom or lab—tools like Science Journal let you see how the world works with just your phone.
https://sciencejournal.withgoogle.com/
Apache License 2.0
536 stars 62 forks source link

Fix action area multiline button alignment #56

Closed noahemmet closed 4 years ago

noahemmet commented 4 years ago

Checklist

Motivation and Context

When using a ActionArea.BarButtonItem with more than one line of text, the buttons will align improperly:

Screen Shot 2019-10-08 at 12 24 46 PM

Description

This changes the stackview's alignment to . firstBaseline and horizontally centers the text:

Two lines:

Screen Shot 2019-10-08 at 12 21 56 PM

One line:

image
googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

noahemmet commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.