googlearchive / science-journal-ios

Use the sensors in your mobile devices to perform science experiments. Science doesn’t just happen in the classroom or lab—tools like Science Journal let you see how the world works with just your phone.
https://sciencejournal.withgoogle.com/
Apache License 2.0
536 stars 62 forks source link

Handle camera button based on camera status #58

Closed mattblair closed 4 years ago

mattblair commented 4 years ago

Checklist

Motivation and Context

When tapped, the camera button in the new action area presented the system camera UI (via UIImagePickerController) without checking camera permissions first. If permissions were not determined or denied, this presented the camera UI with a black background, without explaining why the camera wasn't working.

In addition, the camera button did not have any handling for the case were the brightness sensor was already in use, preventing the use of the camera.

Description

Changes were tested on iOS devices running running iOS 12.4.1 and iPadOS 13, turning permissions on and off, testing with and without the brightness sensor in use, and testing in multitasking modes.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

mattblair commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.