Updating sample to use Application Default Credentials

googlearchive / storage-getting-started-go

This is a simple example of calling the Google Cloud Storage API in Go.

Apache License 2.0

36 stars 8 forks source link

Updating sample to use Application Default Credentials #6

Closed theacodes closed 9 years ago

theacodes commented 9 years ago

@tmatsuo PTAL

gmlewis commented 9 years ago

Let's back up a second... What prompted this change?

As far as the code goes, all I see is that you are now passing some more parameters instead of hard-coding things, and also you removed some ACL stuff...

How does this update the sample to use Application Default Credentials? I seems to me that it already did.

Update: Chatted with Jon - removal of dependence upon the JSON file is the key here. SGTM.

gmlewis commented 9 years ago

LGTM after a few nits are fixed.

theacodes commented 9 years ago

Nits fixed, can you merge @gmlewis?

gmlewis commented 9 years ago

Done. Thanks, Jon.