googlearchive / vrview

Library for embedding immersive media into traditional websites.
http://developers.google.com/cardboard/vrview
Apache License 2.0
1.71k stars 1.09k forks source link

Customizing the color of Hotspots? #233

Closed BrendanCarlin closed 7 years ago

BrendanCarlin commented 7 years ago

I tried adjusting the color properties of hotspots in hotspot-renderer.js, but my project still displays with the default hex values. I saw on a closed 2016 issue that hotspots were not customizable, but I wanted to check in and confirm that this was still the case.

Any assistance is appreciated. Thanks

aerialglasgow commented 7 years ago

Hi Brendan

I was able to alter the hotspot colors here

// Constants for the focus/blur animation. var NORMAL_SCALE = new THREE.Vector3(1, 1, 1); // AERIAL var FOCUS_SCALE = new THREE.Vector3(1.5, 1.5, 1.5); var FOCUS_DURATION = 1000;

// Constants for the active/inactive animation. var INACTIVE_COLOR = new THREE.Color(0x00ABCE); // AERIAL ORIG (1, 1, 1) var HOTSPOT_COLOR_NORMAL = 0x00ABCE; var HOTSPOT_COLOR_ARROW = 0x54A719; var HOTSPOT_COLOR_OUTER = 0xffffff; var ACTIVE_COLOR = new THREE.Color(0.8, 0, 0); // AERIAL ORIG (0.8, 0, 0); var ACTIVE_DURATION = 100; var FOCUSON_ACTIVE_DURATION = 1000; var FOCUSOFF_ACTIVE_DURATION = 200;

// AERIAL Amendments var HOTSPOT_INNER_RADIUS = 32;
var HOTSPOT_INNER_RADIUS_FACTOR = 0.6;
var STANDARD_DISTANCE_FROM_CAMERA = 4;

// Constants for opacity. var MAX_INNER_OPACITY = 0.8; var MAX_OUTER_OPACITY = 0.6; var FADE_START_ANGLE_DEG = 35; var FADE_END_ANGLE_DEG = 60;

You should be able to search the code library for these entries. Hope that helps.

BrendanCarlin commented 7 years ago

Thanks, Aerial. That's where I'm making my adjustments, but I'm not seeing it update in my project. I tested again this morning and it still didn't work. Additionally, I adjusted the color properties on innerMaterial and outerMaterial within HotspotRenderer.prototype.createHotspot but that also didn't work.

After adjusting the source code on hotspot-render.js, do I need to recompile the API using build? I assumed having the entire project directory on the server would be sufficient to reflect those updates when changes were made within the src folder.

aerialglasgow commented 7 years ago

Ah yeah, I think you would have to recompile the API, your changes were probably overwritten

BrendanCarlin commented 7 years ago

aerialglasgow, I made the edits to hotspot-renderer.js then recompiled the API. I'm still not seeing the intended result. Was this the only change you made and did you do it anywhere other than hotspot-renderer.js?

UPDATE: It's working now. I'm not sure why it wasn't before, but I'm good. Thanks again.