googlearchive / vrview

Library for embedding immersive media into traditional websites.
http://developers.google.com/cardboard/vrview
Apache License 2.0
1.71k stars 1.09k forks source link

Walkthrough is missing Step 4 is missing new build commands. #248

Open cwhittl opened 7 years ago

cwhittl commented 7 years ago

https://codelabs.developers.google.com/codelabs/vr_view_101/index.html?index=..%2F..%2Findex#3

$ git clone https://github.com/google/vrview

should be

$ git clone https://github.com/google/vrview $ cd vrview $ npm update $ npm run build

Thanks

AlfkaGit commented 6 years ago

I have gotten this far. I am able to use the old vrview directory and it works. However, since the change to having to execute npm run build, I am not able to get vrview to work. Very basic user here. How and in which program do I execute npm run build. I am trying to host everything in the cloud, no server on my side.

Thanks

AlfkaGit commented 6 years ago

Executnig npm run build from the command prompt, this is what I get

C:\Users\acely\Documents\GitHub\vrview>npm run build

vrview@2.0.1 build C:\Users\acely\Documents\GitHub\vrview npm run build-min; npm run build-dev; npm run build-api

npm WARN invalid config loglevel="notice" npm ERR! missing script: build-min;

npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\acely\AppData\Roaming\npm-cache_logs\2017-10-05T12_45_53_461Z-debug.log npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! vrview@2.0.1 build: npm run build-min; npm run build-dev; npm run build-api npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the vrview@2.0.1 build script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\acely\AppData\Roaming\npm-cache_logs\2017-10-05T12_45_53_491Z-debug.log

jsantell commented 6 years ago

Hello @AlfkaGit -- I think this fix mentioned in another bug here might work for you. We have to update the npm build commands to work on Windows. Hope this helps in the interim!