Closed hasandogu closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
Thanks for the fix!
THREE is using local axis to rotate using Euler and the order is 'XYZ' by default. Before this change, it would rotate around X first for "pitch" which would make local Y is than world Y, once it rotates around local "Y" for yaw the hotspot would end up being in the wrong place. This is not visible in the hotspots example as no pitch is set on any of the hotspots.