googlearchive / vrview

Library for embedding immersive media into traditional websites.
http://developers.google.com/cardboard/vrview
Apache License 2.0
1.71k stars 1.09k forks source link

Cannot build project on Windows #261

Open jsantell opened 6 years ago

jsantell commented 6 years ago

There are bash commands in npm scripts that do not work on Windows.

jsantell commented 6 years ago

Related #232, #248, #234

Also we should no longer require java (closure compiler) to build this project.

jbrthroque commented 6 years ago

how to fix this problem?

jsantell commented 6 years ago

Not use npm scripts (that execute in shell) in package.json but instead call node scripts.

jose-torres-marin commented 6 years ago

EDIT: Please see the comment below for already-built files instead of building your own.

@jbrthroque you can modify the package.json locally if you're in a hurry.

jsantell commented 6 years ago

The links in this PR provide links to the built files in the mean time: https://github.com/googlevr/vrview/pull/262

ksaylor11 commented 6 years ago

I followed the instructions given by @jose-torres-marin and I end up with an error:

missing script: browserify

jsantell commented 6 years ago

try npm install -g browserify

ksaylor11 commented 6 years ago

Still has issues. I've attached the output of running npm run build

result.txt

jsantell commented 6 years ago

Looks like you need browserify installed as a global: npm install -g browserify

ksaylor11 commented 6 years ago

The results I just posted were after installing browserify globally

jose-torres-marin commented 6 years ago

@ksaylor11 Since the readme was updated with direct links to built files, hopefully this is no longer an issue.