googlearchive / vrview

Library for embedding immersive media into traditional websites.
http://developers.google.com/cardboard/vrview
Apache License 2.0
1.71k stars 1.09k forks source link

Add 'allow="vr"' Feature Policy attribute to iframe to permit WebVR #277

Closed ademarre closed 6 years ago

ademarre commented 6 years ago

Add 'allow="vr"' Feature Policy attribute to permit WebVR in cross-origin iframes. As discussed in https://github.com/googlevr/vrview/issues/274#issuecomment-345392899 .

https://github.com/w3c/webvr/issues/86 https://developers.google.com/web/updates/2017/09/webvr-origin-trial-chrome-62 https://bugs.chromium.org/p/chromium/issues/detail?id=666767

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


lincolnfrog commented 6 years ago

@ademarre please sign the CLA and then I will merge. Thank you!

ademarre commented 6 years ago

Please see pull request #278 instead.