search

googlearchive / vrview

Library for embedding immersive media into traditional websites.
http://developers.google.com/cardboard/vrview
Apache License 2.0
1.71k stars 1.09k forks source link

fix hotspot gaze click using bind #292

Open tommytee opened 6 years ago

tommytee commented 6 years ago

https://github.com/googlevr/vrview/commit/8966d4f451245163092a248700ba2805bedaef42 broke gaze-to-click

.bind( this ) is used here (instead of an arrow function)

this pr is an es5 friendly version of https://github.com/googlevr/vrview/pull/291

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

jj-wd commented 6 years ago

Has this been merged meanwhile? I'm unable to compile this branch currently due to some other issues but I downloaded the build files from gh-pages and gazing still doesn't seem to work? Edit: Nevermind, I just added that line to the build file. Works perfectly.