search

googlearchive / web-push-encryption

[Deprecated] Encryption Utilities for Web Push protocol
Apache License 2.0
84 stars 23 forks source link

Tests sendwebpush #11

Closed gauntface closed 8 years ago

gauntface commented 8 years ago

This adds methods for testing sendWebPush in it's current state.

gauntface commented 8 years ago

cc @petele @wibblymat @addyosmani @jeffposnick

Anyone for a review?

jeffposnick commented 8 years ago

Looks good in general. One piece of feedback with a scope that extends outside this PR is that it could be more maintainable to create a standalone file that included an enum-like mapping of error identifiers to error strings, and then refer to the errors via their identifier when constructing them in the library and when checking for them in the test.

gauntface commented 8 years ago

Ta for the review Jeff (The mocha exit with status 0 is super frustrating!!).

Raised an issue regarding the error message (agreed that this doesn't scale well or maintain well) https://github.com/GoogleChrome/push-encryption-node/issues/12

gauntface commented 8 years ago

@wibblymat when you get a chance, I'd appreciate you check over the code in push.js to make sure you are happy with them and I'm not missing anything.

wibblymat commented 8 years ago

Superceded by #18