search

googlearchive / web-push-encryption

[Deprecated] Encryption Utilities for Web Push protocol
Apache License 2.0
84 stars 23 forks source link

Add optional padding #14

Closed wibblymat closed 8 years ago

wibblymat commented 8 years ago

R: @gauntface

gauntface commented 8 years ago

Mostly nits.

Also, this looks like the original implementation was wrong (i.e. if you used encryptPayload directly) you would have gotten different results (i.e. padding added after the encryption occured on payload cs encryption on payload with padding applied).

If so it would be worth adding tests for encryptingPayload - but feel free to raise and issue and we can address in a seperate PR.

wibblymat commented 8 years ago

@gauntface updated. I stopped exposing methods that weren't needed.

gauntface commented 8 years ago

LGTM