search

googlearchive / web-push-encryption

[Deprecated] Encryption Utilities for Web Push protocol
Apache License 2.0
84 stars 23 forks source link

Coordinate with web-push library #15

Open marco-c opened 8 years ago

marco-c commented 8 years ago

I'm the developer of https://github.com/marco-c/web-push, which is another server-side Node.js library for Web Push. In my library, I've implemented push notifications for Firefox (with and without payloads) and Chrome (old GCM method, so without payload). I'm planning to add support for payloads in Chrome (https://github.com/marco-c/web-push/issues/114).

I'm also adding support for VAPID in Firefox (https://github.com/marco-c/web-push/pull/112), and I'm looking forward to Chrome supporting it (https://bugs.chromium.org/p/chromium/issues/detail?id=583753).

I think the two libraries serve the same purpose, and we could merge them to avoid duplicating our efforts.

wibblymat commented 8 years ago

Hi @marco-c! Sorry about not responding earlier. I failed to watch my own repo so didn't see this come in.

How exactly do you envisage merging working? We have similar libraries in other languages (go, java, etc.) in the works and would like to be able to talk about them as a collection once they are all released.

marco-c commented 8 years ago

We could create a GitHub org where we put all the web push libraries (our merged Node.js one, @Minishlink PHP one, and the other ones we will eventually introduce in the future).

marco-c commented 8 years ago

I assume you don't want to do this? Duplicating the work seems a waste of time to me, but I don't want to force you.

gauntface commented 8 years ago

Hey @marco-c that's totally not the case.

We've just been super swamped this side with all sorts going on.

Can we arrange a time to chat (either Hangouts, IRC, Slack, or .....?)

Cheers, Matt

marco-c commented 8 years ago

Hey @gauntface, awesome! IRC would be great, what time works for you (I'm in London, UTC+1 now)? I'm marco in irc://irc.mozilla.org/push.