search

googlearchive / web-push-encryption

[Deprecated] Encryption Utilities for Web Push protocol
Apache License 2.0
84 stars 23 forks source link

Adding tests for sendWebPush #18

Closed wibblymat closed 8 years ago

wibblymat commented 8 years ago

@gauntface This is your PR #11 which I have rebased, fixed after changes on master, and then made a few small changes to.

Biggest functional change is that encrypt now let's message be a String or a Buffer. It should really have been in it's own PR, I guess, but I thought of it while doing this one. ¯\_(ツ)_/¯

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

wibblymat commented 8 years ago

@googlebot

Yeah, well, you know, that's just like, uh, your opinion, man

gauntface commented 8 years ago

@wibblymat what do you want to do about this?

wibblymat commented 8 years ago

It's not a big deal, we just override the check. We just have to make sure that WE believe that everyone has signed a CLA. It was only when we had the strictest form of branch protection on that it was a problem.

On Thu, 31 Mar 2016 at 18:36 Matthew Gaunt notifications@github.com wrote:

@wibblymat https://github.com/wibblymat what do you want to do about this?

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/GoogleChrome/push-encryption-node/pull/18#issuecomment-204043568

gauntface commented 8 years ago

LGTM from me.