throw error if setGCMAPIKey is called with invalid key

googlearchive / web-push-encryption

[Deprecated] Encryption Utilities for Web Push protocol

Apache License 2.0

84 stars 23 forks source link

throw error if setGCMAPIKey is called with invalid key #54

Closed samthor closed 7 years ago

samthor commented 8 years ago

Fixes #21.

wibblymat commented 7 years ago

I believe that #21 is referring to the encryption parameters in the subscription object, not the API key. Maybe not. @owencm, does this solve your issue? If not then we just need to reopen the issue

It looks like we already verify the subscription parameters, though. I would expect these lines to throw if the data isn't base64 encoded.