search

googlearchive / workbox-microsite

Workbox Microsite
Apache License 2.0
24 stars 13 forks source link

manifestDest #64

Closed johnpapa closed 7 years ago

johnpapa commented 7 years ago

cc @jeffposnick

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

jeffposnick commented 7 years ago

Just want to loop in @gauntface on this to see if it makes sense to commit this PR. The changes were made in the upstream JSDocs at https://github.com/GoogleChrome/workbox/pull/602

It might be that we should wait for a new Workbox release, and then this updated text will be picked up in the new versioned docs for that release. Going back and updating previous versioned releases isn't the most scalable model. The flipside is that this was a typo and the fix applies equally to the older releases.

gauntface commented 7 years ago

@johnpapa Sorry, but I'm going to close this. The way our reference docs are built is directly from the github tags and these changes are likely to get overwritten :(

I have seen this get fixed in the source comments so next release should have this all fixed up.

johnpapa commented 7 years ago

k. for future reference, where should community contributions go?

gauntface commented 7 years ago

Reference-doc content is auto-generated from source code which is here: https://github.com/GoogleChrome/workbox/

Styling of reference docs or other pages is in this repo