search

googlearchive / workbox-microsite

Workbox Microsite
Apache License 2.0
24 stars 13 forks source link

Turn off the cleanUrls option in Firebase hosting #67

Closed jeffposnick closed 7 years ago

jeffposnick commented 7 years ago

Fixes #55

As far as I can tell (confirmed by running https://www.npmjs.com/package/spider.js locally and also some regexp searches), there are only three instances of hardcoded links that needed to be cleaned up. I've adjusted those and added in explicit 301 redirects for anyone who had previous links to them.

gauntface commented 7 years ago

@philipwalton is this going to mess with your analytics set up?

philipwalton commented 7 years ago

This shouldn't conflict with the cleanUrlTracker autotrack plugin, but it will mean, going forward, we'll have some duplicate entries in the pageview reports.

That should be OK though, as long as it's a clean break going forward.

googlebot commented 7 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.