googlearchive / workbox-microsite

Workbox Microsite
Apache License 2.0
24 stars 13 forks source link

Replace staticFileGlobs by globPatterns in webpack config #74

Closed supertanuki closed 7 years ago

supertanuki commented 7 years ago

In the "Get Started > webpack" page (https://workboxjs.org/get-started/webpack.html) there is an error in the config:

- staticFileGlobs: ['**/*.{html,js,css}'],
+ globPatterns: ['**/*.{html,js,css}'],
googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


supertanuki commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

jeffposnick commented 7 years ago

Thanks!

jeffposnick commented 7 years ago

(I'm going to make the same change in gulp.md in a separate PR.)