search

googlearchive / workbox-microsite

Workbox Microsite
Apache License 2.0
24 stars 13 forks source link

Set touch-action to pan-y instead of none for sidebar links. #82

Closed jeffposnick closed 7 years ago

jeffposnick commented 7 years ago

I noticed this while visiting the site on a mobile device over the weekend—the sidebar isn't scrollable when you've expanded the Reference section:

workboxjs org-examples- nexus 5x

I don't have the background on why it was set to touch-action: none to begin with, so hopefully this change doesn't have any other impact—perhaps @gauntface knows why it was initially configured that way?

googlebot commented 7 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.