googlecloudrobotics / core

Cloud Robotics Core: Kubernetes, Federation, App Management
Apache License 2.0
193 stars 61 forks source link

Wrong versions in charts are not reported back to chart-assignment status #383

Open ensonic opened 4 months ago

ensonic commented 4 months ago

If one specifies a bad version in an app.yaml / chartassignment.yaml the chart will be stuck in LoadingChart and one needs to consult the chartassignment-controller logs to see

Error: "retrieve chart: chart "kyverno" version "1.12.1" not found in https://kyverno.github.io/kyverno/ repository"

We should check that case here: https://github.com/googlecloudrobotics/core/blob/main/src/go/pkg/controller/chartassignment/release.go#L206

and report the error instead of retrying.