search

googlecloudrobotics / core

Cloud Robotics Core: Kubernetes, Federation, App Management
Apache License 2.0
193 stars 61 forks source link

Add JWT signing utility to cloudrobotics library #410

Closed Ongy closed 2 months ago

csieber commented 2 months ago

Can you split the change into two? One for the metadata-server and one where you use it?

Ongy commented 2 months ago

I'm not quite sure which split you mean.

Currently the metadata-server part is the user of the new API. Using this is out of scope of this repo (the other PR with the new validation endpoint is the closest to user here). I can split the new API (~the first commit) from the metadata-server part.

csieber commented 2 months ago

I'm not quite sure which split you mean.

Currently the metadata-server part is the user of the new API. Using this is out of scope of this repo (the other PR with the new validation endpoint is the closest to user here). I can split the new API (~the first commit) from the metadata-server part.

True. I misunderstood the change. Splitting it as you recommended would be good.