search

googlecodelabs / android-perf-testing

Automated Performance Testing on Android
https://codelabs.developers.google.com/codelabs/android-perf-testing/
Apache License 2.0
93 stars 39 forks source link

Add informational comment at "changeTextSameActivityTest()" method #19

Closed pungrue26 closed 8 years ago

pungrue26 commented 8 years ago

"changeTextSameActivityTest" may fail when test device or emulator uses 3rd party keyboard app. That actually happened to me, and I had to spend some time on finding what went wrong. So, adding some informational comment at the method would help developers who may encounter the same test failure.

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

pungrue26 commented 8 years ago

Weird, I have signed to CLA with the same email address, and double checked in the link that googlebot shared.

I think this may be a timing issue. I just signed CLA right before making this pull request. Please check my CLA again, and tell me what should I do in this situation. :(

pungrue26 commented 8 years ago

I'll simply close this pr, and make a new one hoping it works.

PaulRashidi commented 8 years ago

CLA needs to be signed with the email address that is being committed to Git with btw.