googlebot
commented
7 years ago Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
- In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
idofl
The formatDollars function used maximumFractionDigits as 0, and the style used is "currency", with currency "USD". This causes an exception, and the value is never updated on screen. According to specification, the maximum value should be between the minimum for the style and 20. For currency, the minimum is defined by ISO 4217 according to the currency type, which sets the minimum fraction of USD to 2.