googlecodelabs / codelab-components

Web components for creating codelabs
https://googlecodelabs.github.io/codelab-components/
Apache License 2.0
472 stars 97 forks source link

Make js compiler happy #20

Closed ebidel closed 8 years ago

ebidel commented 8 years ago

R: @aliafshar, @crhym3

This is for g3 import. Makes js compiler :smile:

rictic commented 8 years ago

(I'll leave some inline comments explaining the changes which might otherwise appear kinda weird)

x1ddos commented 8 years ago

Awesome :star2: I wonder if we should add a closure compiler pass as a CI task to at least make sure it stays compatible for future changes.

ebidel commented 8 years ago

Sure. Will file a bug for that though.

ebidel commented 8 years ago

https://github.com/googlecodelabs/codelab-components/issues/21