search

googlecodelabs / codelab-components

Web components for creating codelabs
https://googlecodelabs.github.io/codelab-components/
Apache License 2.0
473 stars 97 forks source link

Polymer 2.x compatibility #49

Open misi opened 6 years ago

misi commented 6 years ago

Do you have any plans to make this Polymer2.x compatible element? Does anyone from this community work on this?

I think it would be helpful to add a notice about that it is not yet a 2.x polymer compatible element.

Thanks for your help in advance!

x1ddos commented 6 years ago

Sorry for not replying earlier. I think we're moving away from Polymer completely and will be porting this to just plain Custom Elements, no frameworks/libraries.

misi commented 6 years ago

Thanks. I am definitely interested in your new project.

I see in chrome this warning, that says with chrome M65 will will break your actual codelab. There are many ways to fix. Could you give me any hints, how to fix it?

[Deprecation] Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M65, around March 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.

Thanks a lot! & Appreciated your help and cooperation!

x1ddos commented 6 years ago

Oh, thanks for reminding me! I completely forgot about that timeline. I'm thinking to create googlecodelabs/codelab-elements, as opposed to this repo codelab-components. Will check back here soon.

/cc @marcacohen @ebidel

x1ddos commented 6 years ago

So, the idea is to re-create <google-codelab>, <google-codelab-step> and <google-codelab-survey> using Custom Elements and style them with help from MDC.

This should be backwards-compatible. Existing exported codelabs markup must not change.

/cc @devnook.

x1ddos commented 6 years ago

FYI created a new repo at https://github.com/googlecodelabs/codelab-elements. It's pretty much empty at the moment though, just a playground for some of my experiments. More coming soon.

misi commented 6 years ago

Thank you for the update. I will check and follow it. (I am not an exprtz on this field, but let me know if I could help..)

billhimmelsbach commented 6 years ago

Just as a head's up, the warning has been updated in Chrome Canary:

screen shot 2018-03-12 at 2 42 08 pm

https://github.com/Polymer/polymer/issues/4679#issuecomment-358477927

x1ddos commented 6 years ago

We've been quite active in the new repo. Things are starting to get into a nice shape. See https://github.com/googlecodelabs/codelab-elements.