search

googlecodelabs / feedback

Provide feedback to our codelabs by filing an issue here
18 stars 22 forks source link

[cloud-dialogflow-assistant-tvguide]: #698

Open LizMyers opened 4 years ago

LizMyers commented 4 years ago

I've found several mistakes in this code lab. The biggest one is that when you get to the end of the lab - the Simulator throws the following error. (Note: valid data is returned, but the Assistant fails to deliver a speech response).

MalformedResponse expected_inputs[0].input_prompt.rich_initial_prompt.items[0].simple_response: 'text_to_speech' or 'ssml' must be set.

BUG FIX: MISSING AMPERSAND Change Line 81 FROM: if(tvresults & tvresults['Listings'][0]) { TO: if(tvresults && tvresults['Listings'][0]) { (

TUTORIAL TEXT BUGS:

  1. Step 4 Intents > Modifying the Default Welcome Intent (Line 3) "...match an intent with watch you just said."
    Should be: "match an intent with what you just said."

  2. Step 4 Intents > Create The Channel Intent > 6. > "Prompts for Channel" box > "2. In which TV channel are you interested in." Change To: "In which TV channel are you interested". (drop the last 'in' - redundant)

  3. Step 5 Fulfillment > 5. "Click the Deploy button. It will take a moment, cause it's deploying your serverless function." Change to: "because"

TEXT DISPLAY OUTPUT BUG 20:00:00 -> Limit time of program to hour : minutes - leave off seconds

TEXT INPUT TIME BUG "What's on Comedy Central at 8PM?" -> returns programming at 8AM Currently you have to enter 8PM in military time (20:00) - IMHO this isn't user-friendly for a US TV guide - where we use AM and PM rather than the 24 hr. clock.

Please note: with voice input all seems to work as intended. (i.e. "What's on Comedy Central at 8 PM?" delivers a parallel spoken response > ..."at 8PM" ).

savelee commented 4 years ago

Thank you Liz. I will fix these ;)