search

googlecodelabs / tools

Codelabs management & hosting tools
Apache License 2.0
4.18k stars 1.13k forks source link

Web serial codelab not working properly #414

Open computersarecool opened 4 years ago

computersarecool commented 4 years ago

Hi,

I don't think this is the correct place to open this issue but I do not know where else to do it, so: This codelab: https://codelabs.developers.google.com/codelabs/web-serial/index.html?index=..%2F..index#2

and specifically the associated glitch link: https://web-serial-codelab-start.glitch.me/ has an issue.

It says: Sorry, Web Serial is not supported on this device, make sure you're running Chrome 78 or later and have enabled the #enable-experimental-web-platform-features flag in chrome://flags even when I have done that.

Furthermore, I can make the Web serial API work fine on my own following other tutorials so it is not a problem on my end. If you tell me how to access that code I can submit a PR or tell me who to contact. Anyway, I hope this gets to the right person. This is the first link that shows up when the topic is searched so it is kind of important.

cassierecher commented 4 years ago

I've reached out to the current maintainer of this codelab to see if they're able to debug it. Thanks for the issue report!

reillyeon commented 4 years ago

The code lab steps are written in a confusing way. The feature detection code is not part of the base project. You add that in the 1st part of step 4 but people don't get there because they assume there is something broken when that message shows up at the end of step 3.