search

googlecodelabs / webrtc-web

Realtime communication with WebRTC
https://codelabs.developers.google.com/codelabs/webrtc-web/
Apache License 2.0
755 stars 351 forks source link

Fixes step06 according to latest specs: sdpParams in RTCIceCandidate constructor and use promises #121

Closed notmariazoe closed 3 years ago

notmariazoe commented 4 years ago

The lack of sdpParams in the RTCIceCandidate constructor was throwing a newly created TypeError as per the latest spec draft and .

Moreover, the usage of callbacks in createOffer was causing a race condition that sometimes led to sending a null offer that caused an error on the other peer.

notmariazoe commented 4 years ago

@samdutton Here are the changes I mentioned yesterday, thanks for looking into it! Should fix Issue #102 as well.

samdutton commented 3 years ago

Thanks Maria! Merged.