search

googlecodelabs / workbox-indexeddb

Apache License 2.0
60 stars 22 forks source link

Chapter 8 - wrong reference to file and background sync not working #16

Open mkimicf opened 5 years ago

mkimicf commented 5 years ago

Under "Add notifications to background sync", it says to replace the code in app/src/sw.js, which I think it meant app/sw.js.

Also, the sync doesn't work, thus no notification. I even tried force sync using the Chrome's DevTools (Chrome DevTools > Application > Service Workers), nothing happens. Please advise.

lou8566 commented 4 years ago

it worked for me, i found the background sync took a minute or so to work. check your code again.

DavidScales commented 4 years ago

Thanks for reporting this issue and sorry for not seeing this earlier. I've corrected the pathing typo.

As far as background sync, I'm not sure what might be causing your issue. I haven't used the API in a while, and I don't have much experience with it myself. But I do remember development feeling a bit flaky in the early days (from caching issues, network issues, etc.). I think I recall that I was often confused by the nuance that turning your connection off via the browser was not necessarily sufficient to trigger a sync, and I had to actually test by toggling my wifi. That could be browser/hardware specific but might be worth a try?